Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Improve error messages on security polling failures #15036

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

rgacogne
Copy link
Member

Short description

Also fix the formatting and clang-tidy warnings in the process.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12765462940

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 44 (0.0%) changed or added relevant lines in 1 file are covered.
  • 28 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.03%) to 64.901%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/dnsdist-secpoll.cc 0 44 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/recursordist/recursor_cache.cc 1 84.35%
pdns/dnsdistdist/dnsdist-secpoll.cc 2 0.0%
modules/lmdbbackend/lmdbbackend.cc 2 72.68%
pdns/recursordist/rec-main.cc 3 62.38%
modules/gpgsqlbackend/spgsql.cc 3 67.7%
pdns/signingpipe.cc 5 84.45%
pdns/recursordist/rec-tcpout.cc 6 50.79%
pdns/misc.cc 6 64.62%
Totals Coverage Status
Change from base Build 12764303024: 0.03%
Covered Lines: 126334
Relevant Lines: 163806

💛 - Coveralls

@rgacogne rgacogne merged commit 5557d8c into PowerDNS:master Jan 14, 2025
81 checks passed
@rgacogne rgacogne deleted the ddist-improve-secpoll-msgs branch January 14, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants