Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document geoiplookup and expose GeoIPQueryAttribute to Lua #14972

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

BozhanL
Copy link
Contributor

@BozhanL BozhanL commented Dec 14, 2024

Short description

Document geoiplookup function (introduced in #6171). Closes #8597
Expose enum GeoIPQueryAttribute from geoipinterface.hh to Lua.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

coveralls commented Dec 16, 2024

Pull Request Test Coverage Report for Build 12939092487

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 35 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.02%) to 64.685%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/lua-record.cc 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/recursordist/recursor_cache.cc 1 84.16%
pdns/recursordist/rec-tcpout.cc 3 61.9%
pdns/iputils.cc 3 56.07%
modules/gpgsqlbackend/spgsql.cc 3 67.94%
pdns/recursordist/pdns_recursor.cc 3 72.45%
pdns/recursordist/test-syncres_cc1.cc 5 89.84%
pdns/signingpipe.cc 5 85.79%
pdns/packethandler.cc 6 72.4%
pdns/dnsdistdist/dnsdist-carbon.cc 6 61.6%
Totals Coverage Status
Change from base Build 12927190209: -0.02%
Covered Lines: 127811
Relevant Lines: 166473

💛 - Coveralls

@miodvallat miodvallat merged commit 2800f06 into PowerDNS:master Jan 24, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: don't have use lua record geoiplookup example
4 participants