-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: connection pool metrics in admin server #3420
Conversation
There's a problem for counting the total amount of created pool connections and solving #3214. Just opened nikita-volkov/hasql-pool#43. |
6e83081
to
8ea24b2
Compare
8ea24b2
to
91979e3
Compare
91979e3
to
b602952
Compare
344bf48
to
f72e77b
Compare
Tried to appease codecov but there's a couple of warnings that cannot be cleared. Will merge. |
f72e77b
to
c712415
Compare
Was thinking how to document this.. so we have three observability elements: logs, metrics and traces. Logs and metrics are obvious. But what about the execution plan and the server-tming? I believe those should go into traces because:
server-timing obviously fits that description. The execution plan, not completely.. but it looks it fits on traces for now. Originally I was thinking to merge the Architecture and Observability pages, since each of our major components have some observability. But I'll keep Observability in its own page for SEO. |
Closes #1526
Added a couple of schema cache load metrics plus 4 pool metrics.
References