Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add statement_timeout set on functions #3056

Merged
merged 1 commit into from
Nov 17, 2023
Merged

feat: add statement_timeout set on functions #3056

merged 1 commit into from
Nov 17, 2023

Conversation

taimoorzaeem
Copy link
Collaborator

This should fix #3001.

steve-chavez
steve-chavez approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@steve-chavez steve-chavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 💯

@steve-chavez
Copy link
Member

Will help in documenting this. We need to move https://postgrest.org/en/stable/references/auth.html#impersonated-role-settings into https://postgrest.org/en/stable/references/transactions.html.

@steve-chavez steve-chavez merged commit 125f10a into PostgREST:main Nov 17, 2023
31 checks passed
@taimoorzaeem taimoorzaeem deleted the statement-timeout branch November 18, 2023 08:11
@steve-chavez
Copy link
Member

@taimoorzaeem Would be better to apply all settings instead of only a special case with statement_timeout. Opened #3061 for tracking that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steve-chavez steve-chavez steve-chavez approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply functions statement_timeout for RPC
2 participants
@taimoorzaeem @steve-chavez