Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow embedding without selecting any column #2574

Merged
merged 3 commits into from
Nov 25, 2022
Merged

feat: Allow embedding without selecting any column #2574

merged 3 commits into from
Nov 25, 2022

Conversation

steve-chavez
Copy link
Member

@steve-chavez steve-chavez commented Nov 25, 2022 •
edited
Loading

Closes #2340

Allows doing

GET /clients?select=id,name,projects!inner()&projects.name=eq.IOS

[{"id":2,"name":"Apple"}]

i.e. filtering on a related table without it showing on the result.

Tasks

  • Implement and tests
  • Fix parsers for correct errors
  • GET /projects should give the same result as GET /projects?select=

@steve-chavez steve-chavez marked this pull request as ready for review November 25, 2022 19:05
@steve-chavez steve-chavez merged commit 5e9dba5 into PostgREST:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenceisla laurenceisla laurenceisla approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When embedding with top-level filtering (inner join), empty parentheses should be allowed
2 participants
@steve-chavez @laurenceisla