Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(err): fix distinct_id, set personless and use a uuid #144

Merged
merged 9 commits into from
Nov 25, 2024
Merged

fix(err): fix distinct_id, set personless and use a uuid #144

merged 9 commits into from
Nov 25, 2024
+24 −23

Conversation

oliverb123
Copy link
Contributor

Ingest will punish you for using a fixed value for distinct_id, so let's not do that.

daibhin
daibhin approved these changes Nov 25, 2024
View reviewed changes
posthog/client.py Show resolved Hide resolved
posthog/exception_capture.py Outdated Show resolved Hide resolved
@oliverb123
Copy link
Contributor Author

I ran black . locally and then committed exactly what it gave me, and CI says it's wrong. Should I care about lint checks?

@daibhin
Copy link
Contributor

daibhin commented Nov 25, 2024

@oliverb123 I think we use ruff instead. My VSCode is just setup to auto format afaik

@daibhin daibhin merged commit db565bc into master Nov 25, 2024
2 checks passed
@daibhin daibhin deleted the olly_err_better_default_distinct_id branch November 25, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin approved these changes

@neilkakkar neilkakkar Awaiting requested review from neilkakkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverb123 @daibhin