Feat/async #85
Merged
Feat/async #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XXL
VisargD
reviewed
Feb 13, 2024
VisargD
reviewed
Feb 13, 2024
| except httpx.HTTPStatusError as err: # 4xx and 5xx errors | ||
| # If the response is streamed then we need to explicitly read the response | ||
| # to completion before attempting to access the response text. | ||
| err.response.read() |
There was a problem hiding this comment.
This might have to be changed to its async version
await err.response.aread() other wise it raises an exception when the API responds with an error code
VisargD
reviewed
Feb 13, 2024
tests/test_async_complete.py
Outdated
| class TestChatCompletions: | ||
| client = AsyncPortkey | ||
| parametrize = pytest.mark.parametrize("client", [client], ids=["strict"]) | ||
| models = read_json_file("./models.json") |
There was a problem hiding this comment.
This needs to be ./tests/models.json
VisargD
reviewed
Feb 13, 2024
|
Closes #33 |
VisargD
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Async Support
Description:
To use instead of importing Portkey, we will have to import AsyncPortkey
This matches the convention of OpenAI, instead of OpenAI, we import AsyncOpenAI to async calls of the SDK
Motivation:
Allows the users to make Async calls for chat, complete and embedding
Related Issues:
#33