Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodetect CSV columns #2993

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Autodetect CSV columns #2993

wants to merge 1 commit into from

Conversation

ferblape
Copy link
Member

This is a WIP

Closes #N

✌️ What does this PR do?

🔍 How should this be manually tested?

👀 Screenshots

Before this PR

After this PR

:shipit: Does this PR changes any configuration file?

  • new environment variable in .env.example?
  • new entry in config/application.yml?
  • new entry in config/secrets.yml?

(Changes in these files might need to update the role in Ansible)

📖 Does this PR require updating the documentation?

  • new site configuration variable?
  • new site template?
  • new module/submodule settings?
  • significant changes in some feature?

false
end

def is_integer?(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename is_integer? to integer?.

false
end

def is_float?(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename is_float? to float?.


private

def is_date?(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename is_date? to date?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants