-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chinese Simplified Translation #124
Conversation
Thank you for your contribution! Can you please keep comments like these preserved, as it allows me, as well as other contributors like you, to easily navigate through translation files? This makes adding and changing strings easier in the future. Also, thanks for pointing out the missing strings for the ebook reader and theme settings. I'll make sure to export them tomorrow. |
@starry-shivam OK! And I will copy these comments to zh-rCN xml file and commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Please wait until I export those two missing strings so you can translate them as well, and then we'll move ahead to merge it
@WeiguangTWK I've exported and merged the main branch into your PR. Now, you can add translations for those missing strings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@starry-shivam Yeaaaa it works |
Merged! Thanks :) |
A string "Made with ❤ by Shivam" is left in English because I think it is better to do so :)
Also options of "Ebook reader" is missing from string xml so I can't translate it.