Emit filepath directly after download finishes (#131)

Signed-off-by: starry-shivam <[email protected]>

app/src/main/java/com/starry/myne/ui/screens/detail/viewmodels/BookDetailViewModel.kt

@@ -37,7 +37,6 @@ import com.starry.myne.utils.book.BookUtils
 import dagger.hilt.android.lifecycle.HiltViewModel
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
-import java.io.File
 import javax.inject.Inject
 
 data class BookDetailScreenState(
@@ -92,20 +91,19 @@ class BookDetailViewModel @Inject constructor(
     ) {
         bookDownloader.downloadBook(book = book,
             downloadProgressListener = downloadProgressListener,
-            onDownloadSuccess = { fileName ->
-                val filepath = bookDownloader.getFilePathForBook(fileName)
-                insertIntoDB(book = book, filepath = filepath)
+            onDownloadSuccess = { filePath ->
+                insertIntoDB(book = book, filePath = filePath)
                 state = state.copy(bookLibraryItem = libraryDao.getItemById(book.id))
             }
         )
     }
 
-    private fun insertIntoDB(book: Book, filepath: String) {
+    private fun insertIntoDB(book: Book, filePath: String) {
         val libraryItem = LibraryItem(
             bookId = book.id,
             title = book.title,
             authors = BookUtils.getAuthorsAsString(book.authors),
-            filePath = filepath,
+            filePath = filePath,
             createdAt = System.currentTimeMillis()
         )
         libraryDao.insert(libraryItem)

app/src/main/java/com/starry/myne/utils/book/BookDownloader.kt

@@ -68,7 +68,7 @@ class BookDownloader(private val context: Context) {
     @SuppressLint("Range")
     fun downloadBook(
         book: Book, downloadProgressListener: (progress: Float, status: Int) -> Unit,
-        onDownloadSuccess: (fileName: String) -> Unit
+        onDownloadSuccess: (filePath: String) -> Unit
     ) {
         val filename = getFilenameForBook(book)
         val uri = Uri.parse(book.formats.applicationepubzip)
@@ -104,7 +104,10 @@ class BookDownloader(private val context: Context) {
                         DownloadManager.STATUS_SUCCESSFUL -> {
                             isDownloadFinished = true
                             progress = 1f
-                            onDownloadSuccess(filename)
+                            val externalFilesDir =
+                                context.getExternalFilesDir(Environment.DIRECTORY_DOWNLOADS)
+                            val filePath = File(externalFilesDir, filename).canonicalPath
+                            onDownloadSuccess(filePath)
                         }
 
                         DownloadManager.STATUS_PAUSED, DownloadManager.STATUS_PENDING -> {}
@@ -137,17 +140,6 @@ class BookDownloader(private val context: Context) {
         }
     }
 
-
-    /**
-     * Returns file path for the given book's file name.
-     * @param fileName name of the file for which file path is required.
-     * @return [String] file path for the given file name.
-     */
-    fun getFilePathForBook(fileName: String): String {
-        val externalFilesDir = context.getExternalFilesDir(Environment.DIRECTORY_DOWNLOADS)
-        return File(externalFilesDir, fileName).canonicalPath
-    }
-
     /**
      * Returns true if book with the given id is currently being downloaded
      * false otherwise.

build.gradle

@@ -1,7 +1,7 @@
 buildscript {
     ext {
         kotlin_version = '1.9.22'
-        gradle_version = '8.3.0'
+        gradle_version = '8.3.1'
         hilt_version = '2.49'
         room_version = '2.6.1'
     }