Skip to content

Commit

Permalink
added PR-templates
Browse files Browse the repository at this point in the history
  • Loading branch information
marchingon12 committed May 7, 2024
1 parent 9c6f5f7 commit c7d28a8
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 0 deletions.
18 changes: 18 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
### Description
<!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. -->

### Related Issue
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
<!--- Please link to the issue here: -->

## Type of change
<!--- Is this a bug fix, adding a feature... -->

### Pull Request checklist
<!-- Before submitting the PR, please address each item. Use [x] to check the boxes -->
- [ ] The commit message follows our guidelines
- [ ] Made sure that your PR is not duplicate
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not (for bug fixes/features). Your PR should pass all CI checks in our Gtihub Actions [Workflow](https://github.com/Pool-Of-Tears/GreenStash/actions)
- [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (*optional*)
17 changes: 17 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/translations_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
### Tanslation language
<!--- add your translation locale here -->

### Translation checklist

<!---
Translations are done by translating the base string resources (English) under:
/app/src/main/res/values/strings.xml
You can translate most conveniently using Android Studio's XML editor, but your preferred XML text editor works too. Explore this guide from Helpshift for Android to learn more about translation strings (https://developers.helpshift.com/android/i18n/)
-->

- [ ] Provide the translated strings inside strings.xml under the appropriate folder.
- [ ] Used the correct locale code (en-US, en-GB, de, es, fr...)
- [ ] Named the folder correctly (values-[locale-code])

0 comments on commit c7d28a8

Please sign in to comment.