This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Fix broken growth behavior #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,7 +47,6 @@ | |||
| position: relative; | |||
| width: 400px; | |||
| border: 1px solid; | |||
| padding: 2px; | |||
There was a problem hiding this comment.
Removing this padding renders the text and the cursor outside the border.
Locally, with your code:
|
I'm not sure how to reproduce the original bug, and your fix. Is it #32? Also, since this seems pretty subtle, is there any chance you can add a test? |
|
Working on a test. |
|
Was my issue all along. |
|
I can't find a good reaction gif, so here's a dog being scared of a chicken: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
white-space: pre-wrapis added to preserve whitespace within the mirror. This was causing long lines without line breaks break in the<textarea>not in the mirror div.