Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

fix paper-input #531 #130

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

christophe-g
Copy link

Fixes (reported in PolymerElements/paper-input#531)
image

Thrown by paper-textarea with initial value and auto-validate like:

<paper-textarea label="autoresizing textarea input" value="will throw" auto-validate></paper-textarea>

In this case, validation happens too early causing a read of this.$.textarea.validity.valid to cause the error (this.$ is undefined)

@christophe-g
Copy link
Author

Comment for reviewer - I branched from origin/2.x maybe causing the merge conflict. Changes are really minimal.

@e111077
Copy link
Contributor

e111077 commented Feb 4, 2019

Hi, we are unfortunately going through a large internal migration of paper-input that may result in a new major release. I'll try to make sure this change gets into that change. That, coupled with this element's owner changing soon may unfortunately cause this to take a while. I recommend a fork if you need this in now.

Copy link
Contributor

@e111077 e111077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a test

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants