add simple tobinary implement

PolyhedraZK · Sep 10, 2024 · b9dfbd4 · b9dfbd4
1 parent beb91a4
commit b9dfbd4
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/ecgo/builder/api.go b/ecgo/builder/api.go
@@ -135,7 +135,16 @@ func (builder *builder) Inverse(i1 frontend.Variable) frontend.Variable {
 //
 // The result in in little endian (first bit= lsb)
 func (builder *builder) ToBinary(i1 frontend.Variable, n ...int) []frontend.Variable {
-	panic("unimplemented")
+	// TODO: Currently this doesn't support MarkBoolean
+	nbBits := builder.field.FieldBitLen()
+	if len(n) == 1 {
+		nbBits = n[0]
+		if nbBits < 0 {
+			panic("invalid n")
+		}
+	}
+
+	return bits.ToBinary(builder, i1, bits.WithNbDigits(nbBits))
 }
 
 // FromBinary packs the given variables, seen as a fr.Element in little endian, into a single variable.