mpi with rayon #169
Open
mpi with rayon #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyong1997
reviewed
Jan 6, 2025
| #[inline] | ||
| /// check the caller's thread is the root thread | ||
| pub fn is_root(&self) -> bool { | ||
| rayon::current_thread_index().unwrap() == 0 |
There was a problem hiding this comment.
I think current_thread_index may not be the actual root. For example, if we start 100 threads with into_par_iter to call current_thread_index only, 50 of them return 0 and the other 50 return 1 on my laptop.
zhiyong1997
reviewed
Jan 6, 2025
| // Use retain to avoid re-checking already synced threads | ||
| pending.retain(|&i| { | ||
| let len = self.threads[i].size(); | ||
| if len >= end { |
There was a problem hiding this comment.
I think it is in general correct to use the len value to check whether new data has been successfully appended to the local buffer. However, I have a concern about the syncronization. In the append function of atomic_vec, the len value seems to have been updated before the actually data is written, which means some other thread may notice the new value of len, and read the dirty data. Will this be a problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.