Feature: Orion PCS Integration #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tonyfloatersu
commented
Nov 21, 2024
•
tonyfloatersu
commented
- Orion (base field / simd field) impls
- Orion MPI functionality (proof aggregating from different parties)
- MPI environment spin up for a real e2e testing
- integrating PCS into GKR configs
tonyfloatersu
added a commit
that referenced
this pull request
Nov 22, 2024
tonyfloatersu
force-pushed
the
feature/orion
branch
from
6aba141 to
0fe9dc4
Compare
tonyfloatersu
force-pushed
the
feature/orion
branch
from
06038ff to
0694446
Compare
…y, ignore simd and mpi vars
…s works, need to read test closely
zhiyong1997
reviewed
Jan 17, 2025
| { | ||
| assert_eq!(simd_vec.len() * PackF::PACK_SIZE, Self::PACK_SIZE); | ||
| let mut temp: Vec<_> = simd_vec.to_vec(); | ||
| temp.reverse(); |
There was a problem hiding this comment.
Is this for gf2x128 and gf2x64 only? reverse here is a little confusing.
Signed-off-by: Zhiyong Fang <[email protected]>
tonyfloatersu
force-pushed
the
feature/orion
branch
from
fbbf6dc to
0c35935
Compare
tonyfloatersu
force-pushed
the
feature/orion
branch
from
221f781 to
22abffa
Compare
zhiyong1997
reviewed
Jan 19, 2025
|
|
||
| fn codeword_len(&self) -> usize; | ||
|
|
||
| fn hamming_weight(&self) -> f64; |
There was a problem hiding this comment.
From the context, I think this refers to the relative distance or minimal relative hamming weight/distance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.