Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Controller Pak management view #91

Draft
wants to merge 64 commits into
base: develop
Choose a base branch
from

Conversation

networkfusion
Copy link
Collaborator

@networkfusion networkfusion commented Mar 17, 2024

Description

Basic support for controller backup.
This PR only supports backups from the main joypad (port 1), but could still be improved.

Motivation and Context

works towards #84

How Has This Been Tested?

Tested working on an official pak.

Screenshots

image

image

Types of changes

  • Improvement (non-breaking change that adds a new feature)
  • Bug fix (fixes an issue)
  • Breaking change (breaking change)
  • Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>

Summary by CodeRabbit

  • New Features

    • Introduced Controller Pak management functionality, including loading, cloning, and repairing data.
    • Added a new menu mode for Joypad Controller Pak, enhancing user access to related features.
    • Implemented a dedicated "CPak Management" option in the settings context menu.
  • Bug Fixes

    • Improved error handling related to Controller Pak operations.
  • Documentation

    • Updated header files to include new function declarations for the Controller Pak management features.

@networkfusion
Copy link
Collaborator Author

@Polprzewodnikowy Please can you review at least the changes in c101dc2 as I am pretty sure it is sub par...

Use const for port.
Use define for path parts.
It is quite broken and not necessary (yet).

// Bonus would be to handle individual per game entries!
if (accessory_is_cpak[0]) {
ui_component_main_text_draw(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ui_component_main_text_draw(
ui_components_main_text_draw(

@ottelo9
Copy link

ottelo9 commented Nov 29, 2024

If you need someone to test it, I have the original Controller PAK and a BlueRetro. Good work so far 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants