-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Controller Pak management view #91
Draft
networkfusion
wants to merge
64
commits into
Polprzewodnikowy:develop
Choose a base branch
from
networkfusion:cpak-management
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add Controller Pak management view #91
networkfusion
wants to merge
64
commits into
Polprzewodnikowy:develop
from
networkfusion:cpak-management
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
networkfusion
force-pushed
the
cpak-management
branch
from
March 19, 2024 17:28
17557e0
to
646c107
Compare
could be worse!
could be worse!
…4FlashcartMenu into cpak-management
Ares uses them as the "CPak" extension, so makes it easier to support.
@Polprzewodnikowy Please can you review at least the changes in c101dc2 as I am pretty sure it is sub par... |
Use const for port. Use define for path parts.
It is quite broken and not necessary (yet).
networkfusion
force-pushed
the
develop
branch
from
November 11, 2024 17:36
7220d37
to
96506ed
Compare
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
|
||
// Bonus would be to handle individual per game entries! | ||
if (accessory_is_cpak[0]) { | ||
ui_component_main_text_draw( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
ui_component_main_text_draw( | |
ui_components_main_text_draw( |
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
networkfusion
commented
Nov 11, 2024
If you need someone to test it, I have the original Controller PAK and a BlueRetro. Good work so far 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basic support for controller backup.
This PR only supports backups from the main joypad (port 1), but could still be improved.
Motivation and Context
works towards #84
How Has This Been Tested?
Tested working on an official pak.
Screenshots
Types of changes
Checklist:
Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>
Summary by CodeRabbit
New Features
Bug Fixes
Documentation