Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings viewer #23

Merged
merged 15 commits into from
Dec 17, 2023

Conversation

networkfusion
Copy link
Collaborator

@networkfusion networkfusion commented Jul 28, 2023

Description

Adds a skeleton for enabling a settings editor.
For now, it just shows the settings (as a viewer).
Fixes descrepency with view for credits.
Improve text to show available actions on the browser.

Motivation and Context

It will help others to finalise the editor implementation in future and enables current users to view the settings.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that adds a new feature)
  • Bug fix (fixes an issue)
  • Breaking change (breaking change)
  • Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>

@networkfusion networkfusion added enhancement New feature or request help wanted Extra attention is needed labels Oct 14, 2023
@networkfusion networkfusion removed the help wanted Extra attention is needed label Dec 17, 2023
@networkfusion networkfusion marked this pull request as ready for review December 17, 2023 19:33
@networkfusion networkfusion changed the title Work towards settings editor Add settings viewer Dec 17, 2023
@Polprzewodnikowy Polprzewodnikowy merged commit 10e5c3e into Polprzewodnikowy:main Dec 17, 2023
2 checks passed
@networkfusion networkfusion deleted the settings-editor branch December 17, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants