Optional Sales Tax #5370
Draft
Optional Sales Tax #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwenxin491
changed the title
PavelMakarchuk
requested changes
Nov 26, 2024
...cyengine_us/parameters/gov/irs/deductions/itemized/salt_and_real_estate/state_sales_tax.yaml
Outdated
Show resolved
Hide resolved
...cyengine_us/parameters/gov/irs/deductions/itemized/salt_and_real_estate/state_sales_tax.yaml
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Dec 12, 2024
There was a problem hiding this comment.
The enum should just determine which income bracket (1 through 19) the household is in
If income is 0 to 20,000 -> 1
if income is 20,001 to 40,000 -> 2
Etc.
There was a problem hiding this comment.
The actual sales tax value is determined separately in a different file
There was a problem hiding this comment.
Follow the exact same format from filing_status.py
Or from any other value_type = Enum
PavelMakarchuk
requested changes
Dec 24, 2024
There was a problem hiding this comment.
could we write a unit test?
|
|
||
|
|
||
| class StateSalesTax(Enum): | ||
| 1 = "0" |
There was a problem hiding this comment.
Suggested change
| 1 = "0" | |
| Zero = "ZERO" |
| from policyengine_us.model_api import * | ||
|
|
||
|
|
||
| class StateSalesTax(Enum): |
There was a problem hiding this comment.
Suggested change
| class StateSalesTax(Enum): | |
| class StateSalesTaxIncomeBracket(Enum): |
| 18 = "275000" | ||
| 19 = "300000" | ||
|
|
||
| class state_sales_tax(Variable): |
There was a problem hiding this comment.
Suggested change
| class state_sales_tax(Variable): | |
| class state_sales_tax_income_bracket(Variable): |
| class state_sales_tax(Variable): | ||
| value_type = Enum | ||
| entity = SPMUnit | ||
| possible_values = StateSalesTax |
There was a problem hiding this comment.
Suggested change
| possible_values = StateSalesTax | |
| possible_values = StateSalesTaxIncomeBracket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023 Optional sales tax tables