Oregon LIHEAP #5333
Draft
Oregon LIHEAP #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 17, 2024 18:01
PavelMakarchuk
requested changes
Nov 17, 2024
policyengine_us/parameters/gov/states/or/liheap/eligibility.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/or/liheap/eligibility.yaml
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5333 +/- ##
==========================================
- Coverage 99.12% 99.03% -0.10%
==========================================
Files 2592 2634 +42
Lines 37707 38299 +592
Branches 162 165 +3
==========================================
+ Hits 37378 37930 +552
- Misses 297 335 +38
- Partials 32 34 +2 ☔ View full report in Codecov by Sentry. |
added 3 commits
November 17, 2024 19:06
added 3 commits
November 19, 2024 06:18
PavelMakarchuk
requested changes
Nov 28, 2024
policyengine_us/reforms/states/oregon/rebate/or_liheap_program.py
Outdated
Show resolved
Hide resolved
policyengine_us/reforms/states/oregon/rebate/or_liheap_program.py
Outdated
Show resolved
Hide resolved
policyengine_us/reforms/states/oregon/rebate/or_liheap_program.py
Outdated
Show resolved
Hide resolved
policyengine_us/reforms/states/oregon/rebate/or_liheap_program.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/or/liheap/eligibility.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
we will have two files:
or_liheap_eligibility.py
or_liheap_income_threshold.py
There was a problem hiding this comment.
Lets add unit tests for each individual file
There was a problem hiding this comment.
add changelog_entry
|
Next step for us is to find the payout amount for the program and see how much people can get - there should be some guidelines |
policyengine_us/parameters/gov/states/or/liheap/or_liheap_eligibility.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/or/liheap/or_liheap_income_threshold.py
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Dec 2, 2024
policyengine_us/parameters/gov/states/or/liheap/eligibility.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/or/liheap/eligibility.yaml
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Dec 4, 2024
policyengine_us/variables/gov/states/or/tax/income/liheap/or_liheap_eligibility.py
Show resolved
Hide resolved
policyengine_us/variables/gov/states/or/tax/income/liheap/or_liheap_income_threshold.py
Outdated
Show resolved
Hide resolved
added 2 commits
December 13, 2024 15:25
PavelMakarchuk
requested changes
Dec 13, 2024
policyengine_us/tests/policy/baseline/gov/states/or/tax/income/or_liheap_income_threshold.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/or/tax/income/liheap/or_liheap_eligibility.py
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Dec 23, 2024
Comment on lines
+3
to
+9
| 2021-10-01: | ||
| spm_unit: 1 | ||
| IncomeRange: 1: | ||
| Electricity_Heating: 410 | ||
| HeatingOil: 600 | ||
| LiquidGas: 600 | ||
| NaturalGas: 435 |
There was a problem hiding this comment.
We need to pick specific variables which each breakdown range will be based on.
Suggested change
| 2021-10-01: | |
| spm_unit: 1 | |
| IncomeRange: 1: | |
| Electricity_Heating: 410 | |
| HeatingOil: 600 | |
| LiquidGas: 600 | |
| NaturalGas: 435 | |
| 2021-10-01: | |
| 1: | |
| 1: | |
| Electricity_Heating: 410 | |
| HeatingOil: 600 | |
| LiquidGas: 600 | |
| NaturalGas: 435 |
There was a problem hiding this comment.
We will have the breakdown categories in the metadata
|
|
||
| metadata: | ||
| period: year | ||
| unit: currency-USD |
There was a problem hiding this comment.
Suggested change
| unit: currency-USD | |
| unit: currency-USD | |
| label: | |
| breakdown: | |
| - spm_unit_size | |
| - | |
| - |
There was a problem hiding this comment.
need to add the variables that are relevant here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #273