Mortgage Interest Deduction 2018-2025 (TCJA) #5241
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 16, 2024 16:09
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5241 +/- ##
==========================================
- Coverage 99.12% 99.00% -0.13%
==========================================
Files 2592 2613 +21
Lines 37707 38057 +350
Branches 162 165 +3
==========================================
+ Hits 37378 37678 +300
- Misses 297 346 +49
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
PavelMakarchuk
requested changes
Oct 17, 2024
policyengine_us/parameters/gov/irs/deductions/itemized/interest/mortgage/cap.yaml
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Oct 22, 2024
policyengine_us/parameters/gov/irs/deductions/itemized/interest/mortgage/cap.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
need a changelog entry
added 4 commits
October 22, 2024 21:26
PavelMakarchuk
requested changes
Nov 1, 2024
changelog_entry.yaml
Outdated
Comment on lines
1
to
5
| Change log | ||
| - bump: minor | ||
| changes: | ||
| - Revised home mortgage interest deduction limits for pre-2017 debt. | ||
| - Updated references. |
There was a problem hiding this comment.
Suggested change
| Change log | |
| - bump: minor | |
| changes: | |
| - Revised home mortgage interest deduction limits for pre-2017 debt. | |
| - Updated references. | |
| - bump: minor | |
| changes: | |
| - Revised home mortgage interest deduction limits for pre-2017 debt. |
There was a problem hiding this comment.
the changelog entry is only updated once with the high level explanation of what the PR is aimed to achieve
added 4 commits
November 4, 2024 11:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5170