Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the regular_tax_before_credits variable and add unit tests #5036

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Refactor the regular_tax_before_credits variable and add unit tests #5036

wants to merge 18 commits into from

Conversation

Mshuning
Copy link
Collaborator

@Mshuning Mshuning commented Sep 6, 2024 •
edited
Loading

Fixes #4817

@Mshuning Mshuning changed the title LA County LIFE transit discount Refactor the regular_tax_before_credits variable and add unit tests Sep 6, 2024
@Mshuning Mshuning changed the title Refactor the regular_tax_before_credits variable and add unit tests Refactor the regular_tax_before_credits variable and add unit tests Sep 6, 2024
PavelMakarchuk
PavelMakarchuk requested changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a start, can you add the relevant tax form lines, especially for the ambiguous variables names
e.g.

# Line 17
dwks19 = ...

policyengine_us/variables/gov/irs/tax/federal_income/capital_gains/dwks6.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/irs/tax/federal_income/capital_gains/dwks9.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/irs/tax/federal_income/capital_gains/dwks9.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/irs/tax/federal_income/capital_gains/dwks9.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/irs/tax/federal_income/capital_gains/dwks9.py Outdated Show resolved Hide resolved
@Mshuning
Copy link
Collaborator Author

Mshuning commented Sep 19, 2024 •
edited
Loading

2017 Instructions for Schedule D
image
2023 Instructions for Schedule D
image
@PavelMakarchuk The differences between the 2017 form and the 2023 form are from step 19 in 2017 to steps 19-21 in 2023.

@Mshuning
Copy link
Collaborator Author

https://www.irs.gov/pub/irs-prior/i1040sd--2017.pdf#page=15
Line 26 says:

  1. Add lines 19 and 20.

https://github.com/PolicyEngine/policyengine-us/blob/master/policyengine_us/variables/gov/irs/tax/federal_income/alternative_minimum_tax/regular_tax_before_credits.py
While the old code:

dwks26 = min_(dwks19, dwks20)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelMakarchuk PavelMakarchuk PavelMakarchuk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor the regular_tax_before_credits variable and add unit tests
2 participants
@Mshuning @PavelMakarchuk