Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to policyengine-us 1.100.0 #90

Merged
merged 10 commits into from
Sep 29, 2024
Merged

Bump to policyengine-us 1.100.0 #90

merged 10 commits into from
Sep 29, 2024

Conversation

MaxGhenis
Copy link
Contributor

@MaxGhenis MaxGhenis commented Sep 28, 2024

Fix #88
Fix #80
Fix #92

@MaxGhenis
Copy link
Contributor Author

MaxGhenis commented Sep 28, 2024

@nikhilwoodruff could you take a look at this? Can't download the PUF. Failed twice.

https://github.com/PolicyEngine/policyengine-us-data/actions/runs/11080393076/job/30791143720#step:6:197

@nikhilwoodruff
Copy link
Contributor

The PUF failed to download because we added a URL for it, prompting the data generation script to try to download it. But that stage of the action doesn't pass through the GitHub token needed to download it. Fixed by adding a manually specified step to create the PUF dataset.

@PolicyEngine PolicyEngine deleted a comment from nikhilwoodruff Sep 28, 2024
@nikhilwoodruff
Copy link
Contributor

Fix #69
Also set the datasets to point to a new release, that I'll create on merge. I can't pre-create it beforehand because then the push action will fail to create it. We should automate this process but it'll probably require some time-intensive trial and error and I'd like to just get this in today.

@nikhilwoodruff
Copy link
Contributor

nikhilwoodruff commented Sep 29, 2024

Adding a 'lite mode' to the tests so they only generate a 10k subset of the ECPS. Also removed the auto-upload since this will produce imperfect datasets. We need to find a solution to GitHub OOM Killed-ing the workers, but for now it means we can't autogenerate datasets in GH actions.

@nikhilwoodruff
Copy link
Contributor

Note: I have the locally produced datasets and am ready to add them to the release after merging, but I'd like to get a third tick here.

@MaxGhenis MaxGhenis merged commit aaf9291 into main Sep 29, 2024
3 checks passed
@MaxGhenis MaxGhenis deleted the issue88 branch September 29, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants