Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added special cases for state_itemized_deductions #198

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Added special cases for state_itemized_deductions #198

wants to merge 16 commits into from

Conversation

noman404
Copy link
Collaborator

@noman404 noman404 commented Jan 7, 2025

Fixes #183

@noman404
updated logic for files separately special cases
dc5d6e7
@noman404
fix bug, added array sum
c4ab084
@noman404
updated pre simulation case for
e1c9047 
state_itemized_deductions
state_taxable_income
state_income_tax_before_non_refundable_credits

added special case for states which failed
@noman404
- variable adjustments
83ec1d9 
- code cleanup
@noman404
remove tx from this PR to move into PolicyEngine#166
e0a9329
@noman404
Merge branch 'main' into noman404/issue131
d37e71b 
# Conflicts:
#	policyengine_taxsim/config/variable_mappings.yaml
@noman404
resolve merge conflicts
f2b2961
@noman404
added states that does not have income tax and set them 0.0
75d00ae
@noman404
bug fix on normal variable calls after pre-simulation and special cases
e9a78e5
@noman404
added special cases for state_agi
05754f6
@noman404
added inputs
84358a9
@noman404
Merge remote-tracking branch 'origin/main'
48781e9 
# Conflicts:
#	output/policyengine_taxsim_household_with_dependent_output.csv
#	output/policyengine_taxsim_household_with_dependent_single_parent_output.csv
#	output/policyengine_taxsim_joint_household_output.csv
#	output/policyengine_taxsim_single_household_output.csv
@noman404
Merge branch 'noman404/issue-182' into noman404/issue184
15821ba
@noman404
added special cases for state_itemized_deductions
b3e0565
@noman404
added special cases for state_standard_deduction
12dc4a3
@noman404
uncomment variables (was disabled for test)
f34ddc0
@PavelMakarchuk
Copy link
Collaborator

This will be obsolete as we have created #5436 in the US repository. This will handle all edge cases aside from states without income tax

@noman404
Copy link
Collaborator Author

noman404 commented Jan 10, 2025 •
edited
Loading

This will be obsolete as we have created #5436 in the US repository. This will handle all edge cases aside from states without income tax

These are still missing and in order to map to 0, we should have the special_cases block, current it does after getting this exception but it would a better implementation to avoid exceptions.

Variable ak_income_tax does not exist.
Variable ak_standard_deduction does not exist.
Variable ak_taxable_income does not exist.
Variable ak_non_refundable_credits does not exist.
Variable ca_non_refundable_credits does not exist.
Variable co_standard_deduction does not exist.
Variable ct_standard_deduction does not exist.
Variable fl_income_tax does not exist.
Variable fl_standard_deduction does not exist.
Variable fl_taxable_income does not exist.
Variable fl_non_refundable_credits does not exist.
Variable id_standard_deduction does not exist.
Variable il_standard_deduction does not exist.
Variable il_non_refundable_credits does not exist.
Variable in_standard_deduction does not exist.
Variable in_taxable_income does not exist.
Variable in_non_refundable_credits does not exist.
Variable ia_non_refundable_credits does not exist.
Variable ks_non_refundable_credits does not exist.
Variable me_standard_deduction does not exist.
Variable ma_standard_deduction does not exist.
Variable ma_taxable_income does not exist.
Variable mn_non_refundable_credits does not exist.
Variable mo_standard_deduction does not exist.
Variable ne_non_refundable_credits does not exist.
Variable nv_income_tax does not exist.
Variable nv_standard_deduction does not exist.
Variable nv_taxable_income does not exist.
Variable nv_non_refundable_credits does not exist.
Variable nh_standard_deduction does not exist.
Variable nh_non_refundable_credits does not exist.
Variable nj_standard_deduction does not exist.
Variable nm_standard_deduction does not exist.
Variable nc_refundable_credits does not exist.
Variable nd_standard_deduction does not exist.
Variable nd_non_refundable_credits does not exist.
Variable oh_standard_deduction does not exist.
Variable ok_non_refundable_credits does not exist.
Variable pa_standard_deduction does not exist.
Variable pa_taxable_income does not exist.
Variable pa_non_refundable_credits does not exist.
Variable sc_standard_deduction does not exist.
Variable sd_income_tax does not exist.
Variable sd_standard_deduction does not exist.
Variable sd_taxable_income does not exist.
Variable sd_non_refundable_credits does not exist.
Variable tn_income_tax does not exist.
Variable tn_standard_deduction does not exist.
Variable tn_taxable_income does not exist.
Variable tn_non_refundable_credits does not exist.
Variable tx_income_tax does not exist.
Variable tx_standard_deduction does not exist.
Variable tx_taxable_income does not exist.
Variable tx_non_refundable_credits does not exist.
Variable ut_standard_deduction does not exist.
Variable wa_standard_deduction does not exist.
Variable wa_taxable_income does not exist.
Variable wa_non_refundable_credits does not exist.
Variable wv_standard_deduction does not exist.
Variable wi_non_refundable_credits does not exist.
Variable wy_income_tax does not exist.
Variable wy_standard_deduction does not exist.
Variable wy_taxable_income does not exist.
Variable wy_non_refundable_credits does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust the outputs to reflect states without state_standard_deduction implementation
2 participants
@noman404 @PavelMakarchuk