Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Simulation to load H5 files and HuggingFace H5 files directly #313

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Allow Simulation to load H5 files and HuggingFace H5 files directly #313

merged 3 commits into from
Nov 29, 2024

Conversation

nikhilwoodruff
Copy link
Contributor

Fixes #312

@nikhilwoodruff nikhilwoodruff added the enhancement New feature or request label Nov 27, 2024
@nikhilwoodruff nikhilwoodruff self-assigned this Nov 27, 2024
anth-volk
anth-volk approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me! Eager to get this merged. Thanks for your work on this.

@anth-volk anth-volk merged commit e1bbf58 into master Nov 29, 2024
3 checks passed
@anth-volk anth-volk deleted the nikhilwoodruff/issue312 branch November 29, 2024 16:08
@nikhilwoodruff nikhilwoodruff restored the nikhilwoodruff/issue312 branch December 5, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anth-volk anth-volk anth-volk approved these changes

Assignees

@nikhilwoodruff nikhilwoodruff

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Simulation to load H5 files and HuggingFace H5 files directly
2 participants
@nikhilwoodruff @anth-volk