Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipython to dependencies #192

Merged
merged 1 commit into from
May 6, 2024

Conversation

lordgrim18
Copy link
Contributor

Fixes #191.
This PR adds IPython to setup.py.

What's changed

This PR updates setup.py to include the ipython package in the general_requirements. The ipython package is now capped from (including) version 7.17.0 to versions less than version 8.

These version constraints were chosen because versions equal to and greater than 7.17.0 require Python >=3.7, while versions less than 7.17.0 require Python >=3.6, and versions equal to and greater than 8 require Python >=3.8.

Changes Made

  • Added ipython to the general_requirements in setup.py.
  • Capped ipython from (including) version 7.17.0 to versions less than version 8 to maintain compatibility with Python versions >=3.7.

Copy link
Contributor

@nikhilwoodruff nikhilwoodruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nikhilwoodruff nikhilwoodruff merged commit c722690 into PolicyEngine:master May 6, 2024
4 checks passed
@lordgrim18 lordgrim18 deleted the issue191 branch May 7, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IPython to setup.py
2 participants