Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded pytest version to 8 #190

Closed

Conversation

masterismail
Copy link
Contributor

fixes #187

@anth-volk
Copy link
Contributor

@masterismail I'm sorry, I didn't even realize this PR was open, as we don't monitor this repo's PRs as closely. Would you mind adding a changelog entry?

@masterismail
Copy link
Contributor Author

No problem at all @anth-volk, I too did't realise that a test was failing. Now added a changelog entry.

@anth-volk anth-volk self-requested a review May 7, 2024 12:27
@anth-volk
Copy link
Contributor

Weirdly, these tests fail, claiming that the version you input already exists. Would you mind rebasing and pushing that? Sorry for the hassle.

@anth-volk
Copy link
Contributor

We're having the same issue. To make sure, did you fully pull the live repo into your fork's master, then rebase off of that? I think that may be the issue here.

@masterismail
Copy link
Contributor Author

We're having the same issue. To make sure, did you fully pull the live repo into your fork's master, then rebase off of that? I think that may be the issue here.

I had run .github/is-version-number-acceptable.sh guess that's causing the issue

@masterismail
Copy link
Contributor Author

sorry for inconvinence, fixed this issue here #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump pytest to version 8
3 participants