update numpy and fix numpy records #117
Conversation
|
Could you try |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 182 182
Lines 8711 8711
Branches 1082 1082
=======================================
Hits 7291 7291
Misses 1176 1176
Partials 244 244
☔ View full report in Codecov by Sentry. |
Fixed |
There was a problem hiding this comment.
OK to merge since the numpy update is obviously a massive plus- just curious about the sorted usage but I doubt it adds that big a time cost. Thanks @feixie!
| @@ -23,7 +23,7 @@ def build_from_node( | |||
| node: "ParameterNode", | |||
| ) -> "VectorialParameterNodeAtInstant": | |||
| VectorialParameterNodeAtInstant.check_node_vectorisable(node) | |||
| subnodes_name = node._children.keys() | |||
| subnodes_name = sorted(node._children.keys()) | |||
There was a problem hiding this comment.
Sorry just remind me why this is necessary? Thanks
There was a problem hiding this comment.
I got this change from this commit: openfisca/openfisca-core@c0782fa
Without it I get the TypeError on unit test runs.
Thanks for contributing! Please remove any top-level sections that do not apply to your changes.
make format && make documentationhas been run.New variable
What's changed
Bumped numpy version to match what's in openfisca-core. Bring in changes from openfisca-core to fix
TypeError: ufunc 'isnan' not supported for the input typesBug fix
What this fixes and how it's fixed
Fixes this issue: PolicyEngine/policyengine-us#2802