fix: Change dataset download func name

PolicyEngine · Dec 7, 2024 · d9a418b · d9a418b
1 parent a7b1e51
commit d9a418b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/policyengine_core/data/dataset.py b/policyengine_core/data/dataset.py
@@ -497,7 +497,7 @@ def download_from_huggingface(
             file=sys.stderr,
         )
 
-        hf_download(
+        download_huggingface_dataset(
             repo=f"{owner_name}/{model_name}",
             repo_filename=file_name,
             version=version,

diff --git a/policyengine_core/simulations/simulation.py b/policyengine_core/simulations/simulation.py
@@ -158,7 +158,7 @@ def __init__(
                         filename = filename.split("@")[0]
                     else:
                         version = None
-                    dataset = hf_download(
+                    dataset = download_huggingface_dataset(
                         owner + "/" + repo, filename, version
                     )
                 datasets_by_name = {

diff --git a/policyengine_core/tools/hugging_face.py b/policyengine_core/tools/hugging_face.py
@@ -14,7 +14,7 @@
     warnings.simplefilter("ignore")
 
 
-def hf_download(repo: str, repo_filename: str, version: str = None):
+def download_huggingface_dataset(repo: str, repo_filename: str, version: str = None):
     """
     Download a dataset from the Hugging Face Hub.
 

diff --git a/tests/core/tools/test_hugging_face.py b/tests/core/tools/test_hugging_face.py
@@ -5,7 +5,7 @@
 from huggingface_hub.errors import RepositoryNotFoundError
 from policyengine_core.tools.hugging_face import (
     get_or_prompt_hf_token,
-    hf_download,
+    download_huggingface_dataset,
 )
 
 
@@ -28,7 +28,7 @@ def test_download_public_repo(self):
                     id=test_id, private=False
                 )
 
-                hf_download(test_repo, test_filename, test_version)
+                download_huggingface_dataset(test_repo, test_filename, test_version)
 
                 mock_download.assert_called_with(
                     repo_id=test_repo,
@@ -58,7 +58,7 @@ def test_download_private_repo(self):
                 ) as mock_token:
                     mock_token.return_value = "test_token"
 
-                    hf_download(test_repo, test_filename, test_version)
+                    download_huggingface_dataset(test_repo, test_filename, test_version)
                     mock_download.assert_called_with(
                         repo_id=test_repo,
                         repo_type="model",
@@ -88,7 +88,7 @@ def test_download_private_repo_no_token(self):
                     mock_token.return_value = ""
 
                     with pytest.raises(Exception):
-                        hf_download(test_repo, test_filename, test_version)
+                        download_huggingface_dataset(test_repo, test_filename, test_version)
                         mock_download.assert_not_called()