-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
British Columbia Disability Credit #468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaohhhh
reviewed
Nov 27, 2023
...eters/gov/provinces/bc/tax/income/credits/disability/additional_amount/max_amount_total.yaml
Outdated
Show resolved
Hide resolved
...ada/parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/younger.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/disability/base.yaml
Outdated
Show resolved
Hide resolved
Yaohhhh
reviewed
Nov 28, 2023
...arameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/eligible_age.yaml
Outdated
Show resolved
Hide resolved
...eters/gov/provinces/bc/tax/income/credits/disability/additional_amount/income_threshold.yaml
Outdated
Show resolved
Hide resolved
...eters/gov/provinces/bc/tax/income/credits/disability/additional_amount/max_amount_total.yaml
Outdated
Show resolved
Hide resolved
...ada/tests/gov/provinces/bc/tax/income/credits/bc_disability_credit/bc_disability_credit.yaml
Outdated
Show resolved
Hide resolved
.../gov/provinces/bc/tax/income/credits/bc_disability_credit/bc_disability_credit_eligible.yaml
Outdated
Show resolved
Hide resolved
...es/gov/provinces/bc/tax/income/credits/bc_disability_credit/bc_disability_credit_eligible.py
Show resolved
Hide resolved
...es/gov/provinces/bc/tax/income/credits/bc_disability_credit/bc_disability_credit_eligible.py
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once done please request review form @Yaohhhh
...es/gov/provinces/bc/tax/income/credits/bc_disability_credit/bc_disability_credit_eligible.py
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/household/person/childcare_received.py
Outdated
Show resolved
Hide resolved
...a/variables/gov/provinces/bc/tax/income/credits/bc_disability_credit/bc_disability_credit.py
Show resolved
Hide resolved
...eters/gov/provinces/bc/tax/income/credits/disability/additional_amount/income_threshold.yaml
Outdated
Show resolved
Hide resolved
...a/variables/gov/provinces/bc/tax/income/credits/bc_disability_credit/bc_disability_credit.py
Outdated
Show resolved
Hide resolved
...a/variables/gov/provinces/bc/tax/income/credits/bc_disability_credit/bc_disability_credit.py
Show resolved
Hide resolved
...arameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/eligible_age.yaml
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Dec 7, 2023
...arameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/eligible_age.yaml
Outdated
Show resolved
Hide resolved
...arameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/eligible_age.yaml
Outdated
Show resolved
Hide resolved
...arameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/eligible_age.yaml
Outdated
Show resolved
Hide resolved
...arameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/eligible_age.yaml
Outdated
Show resolved
Hide resolved
...arameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/eligible_age.yaml
Outdated
Show resolved
Hide resolved
...eters/gov/provinces/bc/tax/income/credits/disability/additional_amount/max_amount_total.yaml
Outdated
Show resolved
Hide resolved
...eters/gov/provinces/bc/tax/income/credits/disability/additional_amount/max_amount_total.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/disability/base.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/disability/base.yaml
Show resolved
Hide resolved
...ovinces/bc/tax/income/credits/bc_disability_credit/bc_disability_credit_additional_amount.py
Outdated
Show resolved
Hide resolved
...a/parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/age_limit.yaml
Outdated
Show resolved
Hide resolved
...eters/gov/provinces/bc/tax/income/credits/disability/additional_amount/income_threshold.yaml
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Jan 8, 2024
...ada/parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/younger.yaml
Outdated
Show resolved
Hide resolved
.../parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/max_amount.yaml
Outdated
Show resolved
Hide resolved
.../parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/max_amount.yaml
Outdated
Show resolved
Hide resolved
.../parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/max_amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/disability/base.yaml
Outdated
Show resolved
Hide resolved
...a/parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/age_limit.yaml
Outdated
Show resolved
Hide resolved
...a/variables/gov/provinces/bc/tax/income/credits/bc_disability_credit/bc_disability_credit.py
Show resolved
Hide resolved
...ovinces/bc/tax/income/credits/bc_disability_credit/bc_disability_credit_additional_amount.py
Outdated
Show resolved
Hide resolved
...ovinces/bc/tax/income/credits/bc_disability_credit/bc_disability_credit_additional_amount.py
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/household/person/childcare_received.py
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Jan 12, 2024
...gov/provinces/bc/tax/income/credits/disability/additional_amount/additional_amount_base.yaml
Outdated
Show resolved
Hide resolved
...gov/provinces/bc/tax/income/credits/disability/additional_amount/additional_amount_base.yaml
Outdated
Show resolved
Hide resolved
...gov/provinces/bc/tax/income/credits/disability/additional_amount/additional_amount_base.yaml
Outdated
Show resolved
Hide resolved
...gov/provinces/bc/tax/income/credits/disability/additional_amount/additional_amount_base.yaml
Outdated
Show resolved
Hide resolved
...gov/provinces/bc/tax/income/credits/disability/additional_amount/additional_amount_base.yaml
Outdated
Show resolved
Hide resolved
..._canada/parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/cap.yaml
Outdated
Show resolved
Hide resolved
...eters/gov/provinces/bc/tax/income/credits/disability/additional_amount/income_threshold.yaml
Outdated
Show resolved
Hide resolved
...eters/gov/provinces/bc/tax/income/credits/disability/additional_amount/income_threshold.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/household/person/childcare_expenses_claimed_by_another_person.py
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Feb 2, 2024
policyengine_canada/variables/household/person/childcare_expenses_claimed_by_another_person.py
Outdated
Show resolved
Hide resolved
..._canada/parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/cap.yaml
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Feb 27, 2024
policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/non_refundable.yaml
Show resolved
Hide resolved
policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/non_refundable.yaml
Outdated
Show resolved
Hide resolved
PavelMakarchuk
approved these changes
Feb 28, 2024
PavelMakarchuk
requested review from
MaxGhenis
and removed request for
Yaohhhh
February 28, 2024 01:27
MaxGhenis
requested changes
Feb 28, 2024
...rovinces/bc/tax/income/credits/disability/additional_amount/childcare_expense_threshold.yaml
Outdated
Show resolved
Hide resolved
...canada/parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/base.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/disability/base.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/disability/cap.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/disability/cap.yaml
Outdated
Show resolved
Hide resolved
MaxGhenis
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464