Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress setup #2221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,34 @@
/build/**
/src/__tests__/__setup__/data.json
# Build outputs
build/
dist/
out/
.next/
coverage/

# Dependencies
node_modules/
**/node_modules/

# Config files
*.config.js

# Public assets
public/

# Cache
.cache/
.eslintcache

# Environment files
.env*
!.env.example

# Test files (optional, depending on your needs)
/src/__tests__/__setup__/data.json
# **/*.test.js
# **/*.spec.js
# **/*.cy.js

# Generated files
*.min.js
*.bundle.js
8 changes: 5 additions & 3 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@
"browser": true,
"node": true,
"es2021": true,
"jest/globals": true
"jest/globals": true,
"cypress/globals": true
},
"extends": [
"eslint:recommended",
"plugin:react/recommended",
"react-app",
"plugin:jsx-a11y/recommended"
"plugin:jsx-a11y/recommended",
"plugin:cypress/recommended"
],
"globals": {
"process": true
Expand All @@ -30,7 +32,7 @@
"ecmaVersion": "latest",
"sourceType": "module"
},
"plugins": ["react", "jest", "jsx-a11y"],
"plugins": ["react", "jest", "jsx-a11y", "cypress"],
"rules": {
// suppress errors for missing 'import React' in files
"react/react-in-jsx-scope": "off",
Expand Down
59 changes: 34 additions & 25 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,37 +1,46 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# Production
build/
dist/
out/
.next/
coverage/

# dependencies
/node_modules
/.pnp
node_modules/
.pnp
.pnp.js

## vscode settings
/.vscode
# IDE settings
.vscode/
.idea/

# testing
/coverage

# production
/build

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

coverage/
cypress/screenshots
cypress/videos
cypress/downloads
src/__tests__/__setup__/data.json

# Cache and logs
.cache/
*.log
logs
npm-debug.log*
yarn-debug.log*
yarn-error.log*

/.gcloudignore
/app.yaml
/main.py
/requirements.txt
.pnpm-debug.log*
.eslintcache
.stylelintcache
**/__pycache__
.env
/src/__tests__/__setup__/data.json
.idea

venv/*
# environment variables
.env*

# Misc
.DS_Store
.gcloudignore
app.yaml
main.py
requirements.txt
5 changes: 1 addition & 4 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,10 @@

# production
/build
/dist

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
Expand Down
15 changes: 14 additions & 1 deletion .prettierrc.json
Original file line number Diff line number Diff line change
@@ -1 +1,14 @@
{}
{
"semi": true,
"trailingComma": "es5",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why you enabled these lint rules. Was this a file that wasn't meant to be merged? Do you feel these would be the best for our linting structure? Or is this personal preference?

"singleQuote": true,
"printWidth": 80,
"tabWidth": 2,
"useTabs": false,
"bracketSpacing": true,
"jsxBracketSameLine": false,
"jsxSingleQuote": false,
"arrowParens": "avoid",
"endOfLine": "auto",
"bracketSameLine": false
}
20 changes: 20 additions & 0 deletions cypress.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
const { defineConfig } = require("cypress");
require("dotenv").config({
path: `.env.${process.env.STAGE_ENV || "development"}`,
});

module.exports = defineConfig({
e2e: {
baseUrl: process.env.REACT_APP_POLICYENGINE_DOMAIN,
supportFile: "cypress/support/e2e.js",
specPattern: "cypress/tests/**/*.cy.js",
},
setupNodeEvents(on, config) {
on("task", {
log(message) {
console.log(message);
return null;
},
});
},
});
37 changes: 37 additions & 0 deletions cypress/support/commands.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/// <reference types="cypress" />
// ***********************************************
// This example commands.ts shows you how to
// create various custom commands and overwrite
// existing commands.
//
// For more comprehensive examples of custom
// commands please read more here:
// https://on.cypress.io/custom-commands
// ***********************************************
//
//
// -- This is a parent command --
// Cypress.Commands.add('login', (email, password) => { ... })
//
//
// -- This is a child command --
// Cypress.Commands.add('drag', { prevSubject: 'element'}, (subject, options) => { ... })
//
//
// -- This is a dual command --
// Cypress.Commands.add('dismiss', { prevSubject: 'optional'}, (subject, options) => { ... })
//
//
// -- This will overwrite an existing command --
// Cypress.Commands.overwrite('visit', (originalFn, url, options) => { ... })
//
// declare global {
// namespace Cypress {
// interface Chainable {
// login(email: string, password: string): Chainable<void>
// drag(subject: string, options?: Partial<TypeOptions>): Chainable<Element>
// dismiss(subject: string, options?: Partial<TypeOptions>): Chainable<Element>
// visit(originalFn: CommandOriginalFn, url: string, options: Partial<VisitOptions>): Chainable<Element>
// }
// }
// }
20 changes: 20 additions & 0 deletions cypress/support/e2e.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// ***********************************************************
// This example support/e2e.ts is processed and
// loaded automatically before your test files.
//
// This is a great place to put global configuration and
// behavior that modifies Cypress.
//
// You can change the location of this file or turn off
// automatically serving support files with the
// 'supportFile' configuration option.
//
// You can read more here:
// https://on.cypress.io/configuration
// ***********************************************************

// Import commands.js using ES2015 syntax:
import "./commands";

// Alternatively you can use CommonJS syntax:
// require('./commands')
32 changes: 32 additions & 0 deletions cypress/tests/us/home.cy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import { checkCountryRedirect } from "../../utils/checkCountryRedirect";

describe("PolicyEngine Homepage", () => {
const regexArg = /the\s(us|u\.s\.|usa|united states)/;

beforeEach(() => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run these tests locally, none of the tests actually run, as I get this error here:

  Running:  home.cy.js                                                                      (1 of 1)


  PolicyEngine Homepage
    1) "before each" hook for "should redirect from root to US homepage by default"


  0 passing (747ms)
  1 failing

  1) PolicyEngine Homepage
       "before each" hook for "should redirect from root to US homepage by default":
     CypressError: `cy.visit()` failed trying to load:

/

We failed looking for this file at the path:

/Users/administrator/Documents/forks/scottrosen14/policyengine-app/

The internal Cypress web server responded with:

  > 404: Not Found

I admit, it may be my setup, as I'm unfamiliar with Cypress, but wanted to highlight this.

cy.visit("/");
});

afterEach(() => {
Object.defineProperty(window.navigator, "language", {
value: window.navigator.language,
configurable: true,
});
});

it("should redirect from root to US homepage by default", () => {
Object.defineProperty(window.navigator, "language", {
value: "",
configurable: true,
});
checkCountryRedirect("us", regexArg);
});

it("should redirect from root to US homepage if browser language is en-US", () => {
Object.defineProperty(window.navigator, "language", {
value: "en-US",
configurable: true,
});
checkCountryRedirect("us", regexArg);
});
});
12 changes: 12 additions & 0 deletions cypress/utils/checkCountryRedirect.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
export const checkCountryRedirect = (country, regexArg = "") => {
cy.location("pathname").should((loc) => {
const path = loc.split("/");
expect(path[1]).to.equal(country);
});

cy.get("#home-used-by").then(($ele) => {
const text = $ele.text()?.toLowerCase();
const regex = new RegExp(regexArg, "i");
expect(regex.test(text)).to.equal(true);
});
};
Loading
Loading