Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove improperly netsted metadata JSON #2066

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

anth-volk
Copy link
Collaborator

@anth-volk anth-volk commented Dec 23, 2024

Fixes PolicyEngine/issues#30

This issue was created by an improper assumption in #2038 whereby the metadata endpoint was improperly documented, and changes based upon the typing documentation created a doubly nested output that does not fit our intended schema. This reverts that, and a future issue will be opened to properly configure this so that the metadata route and service are configured as expected.

@anth-volk anth-volk requested a review from mikesmit December 23, 2024 15:29
Copy link
Collaborator

@mikesmit mikesmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this fixes the problem

@anth-volk anth-volk merged commit c148f00 into master Dec 23, 2024
4 checks passed
@anth-volk anth-volk deleted the fix/nested-metadata-response branch December 23, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants