Refactor metadata to blueprint/service #2039
Merged
+39
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1992 This change migrates the existing /<country>/metadata route to a blueprint. This involved 1. Creating a blueprint for just metadata which adds the /<country>/metadata route 2. Updating the get_metadata function to use a MetadataService instead of directly referencing COUNTRIES. Existing build tests already cover this functionality, but I also ran debug and verified with curl that the route responded appropriately.
anth-volk
requested changes
Dec 4, 2024
There was a problem hiding this comment.
Thanks for your contributions to this @mikesmit! I had two requested changes related to a point you had brought up within the issue itself around what constitutes an "entity" within the API. If you'd prefer to discuss this and collectively make adjustments moving forward to how we do this, I'm totally open to it. Also open to pushing that to a second refactor at a later point. Looking forward to hearing your thoughts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1992
This change migrates the existing //metadata route to a blueprint. This involved
Existing build tests already cover this functionality, but I also ran debug and verified with curl that the route responded appropriately.