Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable state ECPS runs #2009

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Enable state ECPS runs #2009

merged 10 commits into from
Nov 27, 2024

Conversation

anth-volk
Copy link
Collaborator

Fixes #1986

This must be merged before merging the solution to PolicyEngine/policyengine-app#2216. This also requires a minor change to the production database, so once this is approved, please drop a message in this thread so that I can do so before merging the approved code.

This PR creates a new policy descriptor, "dataset", that the back end consumes and stores, in order to allow any given region to be run against an enhanced CPS sim run. At the moment, the only possible value of for this descriptor is "enhanced_cps". However, the PR maintains backward compatibility with the "enhanced_us" region that we previously used for US-wide enhanced CPS runs.

@anth-volk
Copy link
Collaborator Author

anth-volk commented Nov 25, 2024

Going to also work #2015 into this PR

Note: If #2006 is merged before this, merge conflicts will need to be solved

Copy link
Collaborator

@nikhilwoodruff nikhilwoodruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great. But just thinking about backwards compatibility- do we need to add a general redirect on the app side for old links?

Edit: reading comprehension fail. Though does raise the question of whether the compatibility should be API side or app side.

@anth-volk
Copy link
Collaborator Author

You know, you make a good point - we could just use one redirect for inbound links. Let me think through this a bit. I might make some modifications and re-request review afterward. If that'd be cleaner and easier, I'm all for it, I just want to make sure it doesn't make loading time extreme for users.

@anth-volk anth-volk merged commit 1b11eea into master Nov 27, 2024
4 checks passed
@anth-volk anth-volk deleted the feat/1986-enable-state-ecps branch November 27, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable states to be run over enhanced_cps
2 participants