Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Americanize country agnostic code #1906

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

tawandamoyo
Copy link
Collaborator

@tawandamoyo tawandamoyo commented Oct 23, 2024

Partially fixes #1543

@tawandamoyo tawandamoyo marked this pull request as ready for review October 23, 2024 18:29
@anth-volk
Copy link
Collaborator

@tawandamoyo Unfortunately, there are quite a few points in the front end where the output of this API route is utilized, and they all refer to a "labour_supply_impact" or something similar. Would you be willing to Americanize those, as well? Otherwise, these changes will just crash on the front end.

@tawandamoyo
Copy link
Collaborator Author

@anth-volk , sure will open a PR for the frontend

@anth-volk anth-volk force-pushed the fix/1543-americanize-country-agnostic-code branch from c6a5258 to ace8410 Compare November 19, 2024 22:29
@anth-volk
Copy link
Collaborator

@tawandamoyo Just updated this to deal with some merge conflicts on the API. After tests are run, I believe this will be good to merge, followed by the corresponding front-end fixes. Thanks for your patience.

@anth-volk anth-volk self-requested a review November 19, 2024 23:04
Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @tawandamoyo! Before merging, https://github.com/PolicyEngine/policyengine-app/pull/2149/files will need to be reviewed and approved. Then we'll merge this, followed by that one.

@anth-volk anth-volk merged commit c90d50a into master Nov 19, 2024
4 checks passed
@anth-volk anth-volk deleted the fix/1543-americanize-country-agnostic-code branch November 19, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Americanize country-agnostic code
2 participants