Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boundingbox function #326

Merged
merged 21 commits into from
Nov 18, 2024
Merged

Add boundingbox function #326

merged 21 commits into from
Nov 18, 2024

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented Nov 10, 2024

Get the bounding box from

  • GeoJSON
  • abstract occurrence collection
  • other layer

Closes #325

Also needs

  • tag v1.1.0
  • add a how-to section specifically on this
  • tests

Copy link
Contributor

Documentation websites for this pull request
📦 SpeciesDistributionToolkit
🌿 GBIF
📊 Fauxcurrences
🐾 OccurrencesInterface
🗺 SimpleSDMLayers
💾 SimpleSDMDatasets
✏️ Phylopic
🧠 SDeMo

@tpoisot tpoisot changed the title Add boundinbox function Add boundingbox function Nov 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 46.80%. Comparing base (43880a9) to head (6eb4b0c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/boundingbox.jl 0.00% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   47.57%   46.80%   -0.78%     
==========================================
  Files          67       68       +1     
  Lines        1753     1784      +31     
==========================================
+ Hits          834      835       +1     
- Misses        919      949      +30     
Flag Coverage Δ
unittests 46.80% <0.00%> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpoisot
Copy link
Member Author

tpoisot commented Nov 13, 2024

Padding is inverted, this shrinks the box instead of expanding it

@tpoisot tpoisot merged commit b50fc08 into main Nov 18, 2024
18 checks passed
@tpoisot tpoisot deleted the sdt/feat/bbox branch November 18, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic function to get a bounding box in WGS84 from an arbitrary object
2 participants