Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the sample function #195

Closed
wants to merge 6 commits into from
Closed

Fix the sample function #195

wants to merge 6 commits into from

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented Jun 2, 2023

Closes #194

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.05 ⚠️

Comparison is base (dd9248f) 53.36% compared to head (147c3f8) 52.32%.

❗ Current head 147c3f8 differs from pull request most recent head 65aa55c. Consider uploading reports for the commit 65aa55c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   53.36%   52.32%   -1.05%     
==========================================
  Files          59       38      -21     
  Lines        1692     1034     -658     
==========================================
- Hits          903      541     -362     
+ Misses        789      493     -296     
Flag Coverage Δ
unittests 52.32% <ø> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tpoisot tpoisot closed this Oct 14, 2023
@tpoisot tpoisot deleted the tpoisot/issue194 branch September 13, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sample does not generate the expected number of background points
2 participants