Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clientapi): add operation name and errors to otel instrumentation #1021

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

kschelonka
Copy link
Contributor

Tested locally to confirm the attributes were sent as expected.

Note that "graphql.errors" will be true for 'unauthorized' error, but it will not show an error reason in the 'critical' error field.

@kschelonka kschelonka requested a review from a team as a code owner January 9, 2025 19:47
@kschelonka kschelonka requested review from Gio2018 and removed request for a team January 9, 2025 19:47
@kschelonka kschelonka enabled auto-merge (squash) January 9, 2025 19:48
Copy link

github-actions bot commented Jan 9, 2025

Plan Result (@infrastructure/parser-graphql-wrapper-production)

CI link

Plan: 0 to add, 1 to change, 0 to destroy.
  • Update
    • aws_appautoscaling_target.application_autoscaling_autoscaling_target_42BF5C99
Change Result (Click me)
  # aws_appautoscaling_target.application_autoscaling_autoscaling_target_42BF5C99 will be updated in-place
  ~ resource "aws_appautoscaling_target" "application_autoscaling_autoscaling_target_42BF5C99" {
        id                 = "service/ParserGraphQLWrapper-Prod/ParserGraphQLWrapper-Prod"
      ~ max_capacity       = 35 -> 20
      ~ min_capacity       = 20 -> 8
        tags               = {}
        # (6 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

⚠️ Errors

@kschelonka kschelonka merged commit 58ea61e into main Jan 9, 2025
209 checks passed
@kschelonka kschelonka deleted the feat/otel-operation-attributes branch January 9, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants