fix(analytics): adding in a way to get mac analytics #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassrock
force-pushed
the
mac-analytics
branch
2 times, most recently
from
d835d2b
to
33a30aa
Compare
Gio2018
approved these changes
Jan 22, 2024
Analytics: Coverage: 68.83
AnalyticsTests: Coverage: 35.8
Generated by 🚫 Danger Swift against d27783b |
|
@bassrock will Mac events appear with a separate API ID as well? I can't recall what the existing Mac app ID is, but perhaps we can re-use that one. |
|
No it won't. Would that make this easier? |
bassrock
force-pushed
the
mac-analytics
branch
from
33a30aa
to
56c8518
Compare
bassrock
force-pushed
the
mac-analytics
branch
from
f98f14b
to
1f8d537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we have no way to segment our analytics by Mac users. This at least will let us attribute actions to mac users, even if the internal snowplow data still says its iPad.
Hopefully snowplow/snowplow-ios-tracker#863 gets traction to give us better tracking.