Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aliases into wait keyword for cypress tests #19

Closed
lucas-louis opened this issue Mar 12, 2022 · 1 comment
Closed

feat: add aliases into wait keyword for cypress tests #19

lucas-louis opened this issue Mar 12, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@lucas-louis
Copy link
Member

[FEATURES] Add wait aliases for cypress tests

Description

In order to avoid crashed tests with cypress, because of the too long time response for the loading/ downloading/ uploading, the use of aliases into the tests will be good.

Is your feature request related to a problem? Please describe.

Sometimes, the loading/ uploading/ downloading is too long for the tests, so they crashed.

Describe the solution you'd like

The use of aliases with the wait keyword, will fix this problem.
The wait keyword could wait with a specific time (like all the tests right now) AND with a condition too, like "you wait until this event is triggered".
So instead of putting a wait of 2 seconds, for example, we could put a wait until a specific toast is displayed (the toast is the one telling that the download/ load/ upload is done)

@lucas-louis lucas-louis added the enhancement New feature or request label Mar 12, 2022
RezaRahemtola added a commit that referenced this issue Jul 4, 2022
Aliases added instead of fixed wait values
@RezaRahemtola RezaRahemtola self-assigned this Jul 5, 2022
@RezaRahemtola
Copy link
Member

Using aliases is not needed for cy.visit() as it already waits for the page to load.

A lot of useless waits where removed so the e2e tests are now 17% faster.

I‘m closing this issue and moving the remaining part in a bullet point of #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants