feat(tests): Useless waits removed (#19)

PoCInnovation · Jul 5, 2022 · 94d29d5 · 94d29d5
1 parent c2a462d
commit 94d29d5
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 18 deletions.
diff --git a/cypress/e2e/features/files.cy.ts b/cypress/e2e/features/files.cy.ts
@@ -2,9 +2,7 @@ let dashboardSpecMnemonic = '';
 
 describe('Create account for File tests', () => {
 	it('Connect', () => {
-		cy.intercept('/signup').as('getSignup');
 		cy.visit('/signup');
-		cy.wait('@getSignup');
 		cy.get('#ipc-signup-credentials-signup-button').click();
 		cy.get('#ipc-signup-text-area')
 			.invoke('val')
@@ -19,13 +17,11 @@ describe('Upload a file modal in Dashboard', () => {
 	const fixtureFile = 'upload_test_file.txt';
 
 	beforeEach(() => {
-		cy.intercept('/login').as('getLogin');
 		cy.visit('/login');
-		cy.wait('@getLogin');
 		cy.get('#ipc-login-text-area').click().type(dashboardSpecMnemonic);
-		cy.get('#ipc-login-credentials-button').click().wait(3000);
+		cy.get('#ipc-login-credentials-button').click();
 		cy.get('#ipc-dashboard-drawer-button').click({ force: true });
-		cy.get('#ipc-upload-button').click().wait(2500);
+		cy.get('#ipc-upload-button').click();
 	});
 
 	it('Good number of buttons after upload', () => {
@@ -45,13 +41,11 @@ describe('Upload an empty file in Dashboard', () => {
 	const fixtureFile = 'upload_empty_file.txt';
 
 	beforeEach(() => {
-		cy.intercept('/login').as('getLogin');
 		cy.visit('/login');
-		cy.wait('@getLogin');
 		cy.get('#ipc-login-text-area').click().type(dashboardSpecMnemonic);
-		cy.get('#ipc-login-credentials-button').click().wait(3000);
+		cy.get('#ipc-login-credentials-button').click();
 		cy.get('#ipc-dashboard-drawer-button').click({ force: true });
-		cy.get('#ipc-upload-button').click().wait(2500);
+		cy.get('#ipc-upload-button').click();
 	});
 
 	it('Good number of buttons after failed upload', () => {
@@ -67,9 +61,7 @@ describe('Download a file in Dashboard', () => {
 		cy.visit('/login');
 		cy.get('#ipc-login-text-area').click().type(dashboardSpecMnemonic);
 		cy.get('#ipc-login-credentials-button').click();
-		cy.wait(2500);
 		cy.get('#ipc-dashboard-download-button').click();
-		cy.wait(3000);
 	});
 
 	it('Good content for downloaded file', () => {

diff --git a/cypress/e2e/features/programs.cy.ts b/cypress/e2e/features/programs.cy.ts
@@ -17,9 +17,9 @@ describe('Upload a program modal for Dashboard', () => {
 	beforeEach(() => {
 		cy.visit('/login');
 		cy.get('#ipc-login-text-area').click().type(dashboardSpecMnemonic);
-		cy.get('#ipc-login-credentials-button').click().wait(3000);
+		cy.get('#ipc-login-credentials-button').click();
 		cy.get('#ipc-dashboard-drawer-button').click({ force: true });
-		cy.get('#ipc-deploy-button').click().wait(2500);
+		cy.get('#ipc-deploy-button').click();
 	});
 
 	it('Good number of buttons after upload', () => {

diff --git a/cypress/e2e/front/dashboard.cy.ts b/cypress/e2e/front/dashboard.cy.ts
@@ -37,7 +37,7 @@ describe('Good Upload file modal front in Dashboard', () => {
 	it('Go to upload modal into dashboard', () => {
 		cy.visit('/login');
 		cy.get('#ipc-login-text-area').click().type(dashboardSpecMnemonic);
-		cy.get('#ipc-login-credentials-button').click().wait(3000);
+		cy.get('#ipc-login-credentials-button').click();
 		cy.get('#ipc-dashboard-drawer-button').click({ force: true });
 		cy.get('#ipc-upload-button').click();
 	});
@@ -67,7 +67,7 @@ describe('Good Deploy program modal front in Dashboard', () => {
 	it('Go to upload modal into dashboard', () => {
 		cy.visit('/login');
 		cy.get('#ipc-login-text-area').click().type(dashboardSpecMnemonic);
-		cy.get('#ipc-login-credentials-button').click().wait(3000);
+		cy.get('#ipc-login-credentials-button').click();
 		cy.get('#ipc-dashboard-drawer-button').click({ force: true });
 		cy.get('#ipc-deploy-button').click();
 	});

diff --git a/cypress/e2e/signup.cy.ts b/cypress/e2e/signup.cy.ts
@@ -55,7 +55,6 @@ describe('Signup with credentials Button for Signup', () => {
 	it('Go to signup', () => {
 		cy.visit('/signup');
 		cy.get('#ipc-signup-credentials-signup-button').click();
-		cy.wait(1000);
 		cy.get('#ipc-signup-copy-mnemonics-button').click();
 	});
 
@@ -69,7 +68,6 @@ describe('Signup with credentials Button for Signup', () => {
 	});
 
 	it('Good URL redirect for close button', () => {
-		cy.wait(1000);
 		cy.get('#ipc-modal-close-button').click().url().should('eq', 'http://localhost:8080/dashboard');
 	});
 });