Reorganize module hierarchy #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeungheonOh
reviewed
Nov 4, 2024
| @@ -0,0 +1,810 @@ | |||
| {-# LANGUAGE FlexibleInstances #-} | |||
There was a problem hiding this comment.
This is quite massive. More so than I thought, would it be better to make Plutarch.Builtins.XYZ modules instead?
|
Will also resolve #735 |
|
Notes: this is closed because of nasty conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first attempt to try and make some sense of the module hierarchy. The overall goals were:
Plutarch.Preludeand get everything they needPlutarch.Prelude, only things in thePlutarch.Internal.*namespaceplutarch-ledger-apiandplutarch-testlibshould rely minimally on imports fromPlutarch.Internal.*Additionally, there were a couple of changes:
pbuiltinMyBuiltinNameinPlutarch.Internal.Builtin, allowing them to be called without having to wonder what their signatures are.Plutarch.*has been significantly emptied.Plutarch.Internal.Builtincontains (most of) the types that we have to have because they're mandated by Plutus.This is not the final outcome, I just wanted to get something reviewed and merged, or the diffs would get too huge.