Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add C API header #19

Merged
merged 30 commits into from
Apr 11, 2024
Merged

feat: Add C API header #19

merged 30 commits into from
Apr 11, 2024

Conversation

jedekar
Copy link
Collaborator

@jedekar jedekar commented Mar 15, 2024

No description provided.

@jedekar jedekar self-assigned this Mar 15, 2024
@chenda6
Copy link
Collaborator

chenda6 commented Mar 21, 2024

Could you please also make sure the live-packager tests are building successfully? Need to add -DBUILD_LIVE_TEST=1 when running cmake. We should probably add this to the workflow file too.

packager/live_packager.cc Outdated Show resolved Hide resolved
include/packager/live_packager_export.h Outdated Show resolved Hide resolved
include/packager/live_packager.h Outdated Show resolved Hide resolved
packager/live_packager.cc Outdated Show resolved Hide resolved
packager/CMakeLists.txt Outdated Show resolved Hide resolved
@jedekar jedekar requested a review from chenda6 March 27, 2024 19:38
include/packager/live_packager_export.h Outdated Show resolved Hide resolved
packager/live_packager_export.cc Outdated Show resolved Hide resolved
packager/live_packager_export.cc Outdated Show resolved Hide resolved
packager/live_packager.cc Outdated Show resolved Hide resolved
lfordyce
lfordyce previously approved these changes Apr 2, 2024
chenda6
chenda6 previously approved these changes Apr 9, 2024
.github/workflows/build-attach-artifacts.yaml Outdated Show resolved Hide resolved
@jedekar jedekar dismissed stale reviews from chenda6 and lfordyce via b9f8727 April 11, 2024 13:58
@chenda6
Copy link
Collaborator

chenda6 commented Apr 11, 2024

Great work getting this done!

@chenda6 chenda6 merged commit 21b8987 into pluto-cmake Apr 11, 2024
27 checks passed
@chenda6 chenda6 deleted the feature/c branch April 11, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants