Skip to content

Commit

Permalink
cleanup comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lee.fordyce committed Mar 1, 2024
1 parent b0c5722 commit 9d6e227
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
3 changes: 0 additions & 3 deletions include/packager/live_packager.h
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,6 @@ struct LiveConfig {
/// Used for timed text packaging to set the fragment decode time when the
/// output format is either VTT in MP4 or TTML in MP4.
int64_t timed_text_decode_time = -1;

/// Timed Text time scale used for packaging VTT in MP4 or TTML in MP4.
uint32_t timed_text_timescale = 10000000;
};

class LivePackager {
Expand Down
4 changes: 2 additions & 2 deletions include/packager/packager.h
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ struct PackagingParams {
/// Flag used to adjust negative CTS offset values to correct PTS < DTS
bool cts_offset_adjustment = false;

/// Flag used as a workaround to produce output segments when the input is a
/// header only VTT file
/// Flag used as a workaround in the case of header only input WEBVTT and the
/// need to produce an output segment
bool webvtt_header_only_output_segment = false;
};

Expand Down
4 changes: 2 additions & 2 deletions packager/media/demuxer/demuxer.h
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ class Demuxer : public OriginHandler {
bool dump_stream_info_ = false;
// flag used to adjust negative CTS offset values to correct PTS < DTS
bool cts_offset_adjustment_ = false;
// flag used as a workaround to generate output segment in the case of input
// WEBVTT with header only
// flag used as a workaround in the case of header only input WEBVTT and the
// need to produce an output segment
bool webvtt_header_only_output_segment_ = false;
Status init_event_status_;
};
Expand Down
4 changes: 2 additions & 2 deletions packager/media/formats/webvtt/webvtt_parser.cc
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,8 @@ bool WebVttParser::Flush() {
// This happens when we parse an empty webvtt file (only contains a header)
if (initialized_ && !stream_info_dispatched_) {
if (webvtt_header_only_output_segment_) {
// This is a workaround in the case of input VTT and output VTT (or TTML)
// in MP4 where we need to generate and output MP4 segment.
// This is a workaround in the case of header only input WEBVTT and the
// need to produce an output segment
std::vector<std::string> block;
block.emplace_back(R"(00:00:00.000 --> 00:00:00.001)");
ParseCue("", block.data(), block.size());
Expand Down

0 comments on commit 9d6e227

Please sign in to comment.