Cc memory fixes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging changes from video-dev#2309 and applying the CC fixes.
adding code to remvoe the cues after 5 mins for live and setting the state to idle for any error not just subtitle related.
ladera
reviewed
Oct 17, 2019
| if (syncPTS + ((vttCCs[cc].start * 90000) || 0) < 0) { | ||
| syncPTS += 8589934592; | ||
| } | ||
| // if (syncPTS + ((vttCCs[cc].start * 90000) || 0) < 0) { |
There was a problem hiding this comment.
doesnt this do some syncing for over 12 hrs of running video ? may be check if thats this logic ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Adds the fixes from PR video-dev#2309
Applying logic to remove the cues after 5 mins and ignoring non-subtitle related error changes.
Fixing the logic for PTS and start time calculations
Why is this Pull Request needed?
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist