Various fixes #38
Merged
Various fixes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note getKitByName should be avoided as kit names may change
# Conflicts: # .github/CHANGELOG.md # MiniGamesBox Classic/build.gradle.kts # MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/KitRegistry.java # MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/basekits/Kit.java # MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/utils/engine/ScriptEngineHandler.java # MiniGamesBox Classic/src/main/resources/kits/knight.yml # gradle.properties
|
With commit 8e01d1d, this means that each plugin has to handle with setting their own default kit. |
|
Mark - Start up issue with kits fixed. |
This may break other plugins, further testing and confirmation is required
Took 9 seconds
Took 2 minutes
Took 3 minutes
Took 21 minutes
Took 3 minutes
Took 25 minutes
Took 8 minutes
Took 17 seconds
Took 9 minutes
Took 6 minutes
|
Complete for merging |
Took 10 minutes
Took 51 minutes
Took 1 minute
|
Have fun with the code review max. Everything should now be fixed. |
|
Tigerpanzer02
added a commit
that referenced
this pull request
Jan 13, 2024
* Bump version from 1.3.5 to 1.3.5-SNAPSHOT0 * More Kit enabled checks * Bump version from 1.3.5-SNAPSHOT0 to 1.3.5-SNAPSHOT1 * Fixed kit loading & arena starting, Default config.yml changes, Added more debug messages (#38) For reference: config.yml Kits: removed Kit.Enabled and Kit.Default-Kit added Rewards set to false by default Removed default_kit from kitsname.yml files * Bump version from 1.3.3 to 1.3.3-SNAPSHOT0 * Fixed script engine on upper java 11/(15) * Moved kits.yml into kits folder, separate file per kit * Bump version from 1.3.3-SNAPSHOT0 to 1.3.3-SNAPSHOT1 * Added getKitByKey and getKitByName Note getKitByName should be avoided as kit names may change * Merging changes * Removed default kit config option from KitRegistry.loadKitConfig * Moved config options * Converted KitRegistry.java to use FileUtils * Added even more debug messages * Added outputs for performance monitoring * Potential fix for tb This may break other plugins, further testing and confirmation is required * Reformat file Took 9 seconds * Re-sequenced changes to arena state Took 2 minutes * Revert for redundancy in setting timer Took 3 minutes * Added ArenaUpdate debug message Took 21 minutes * Moved ArenaUpdate debug message Took 3 minutes * Fixes that Max came up with Took 25 minutes * Kits config options Took 8 minutes * Changes by Max Took 17 seconds * Default kit loading moved to MiniGamesBox Took 9 minutes * Fix for kits config file being loaded on startup Took 6 minutes * Fix for default kit Took 10 minutes * Fix for a kit config option issue Took 51 minutes * Sub-fixes Took 9 seconds * Redundancy checks for disabling kits and config.yml added more comments Took 7 minutes * Fix for a console display issue Took 1 minute * Update KitRegistry.java --------- Co-authored-by: version-bump[github-action] <41898282+version-bump[github-action]@users.noreply.github.com> Co-authored-by: Tigerpanzer_02 <[email protected]> * Bump version from 1.3.5-SNAPSHOT1 to 1.3.5-SNAPSHOT2 * Moved Plugin-Chat-Format to Chat.Format in config.yml * Bump version from 1.3.5-SNAPSHOT2 to 1.3.5-SNAPSHOT3 * Removed legacy particles on newer version to prevent IllegalArgumentException because no class found of modern material * Bump version from 1.3.5-SNAPSHOT3 to 1.3.5-SNAPSHOT4 * Cleaned up ActionBarManager * Bump version from 1.3.5-SNAPSHOT4 to 1.3.5-SNAPSHOT5 * Fixed NPE on Setup MaterialLocationItem / Multi Handleritem RIGHT_CLICK_AIR * Bump version from 1.3.5-SNAPSHOT5 to 1.3.5-SNAPSHOT6 * Fixed IAE Cannot measure distance between worlds if players are in different worlds * Bump version from 1.3.5-SNAPSHOT6 to 1.3.5-SNAPSHOT7 * Adjusted CHANGELOG.md * Bump version from 1.3.5-SNAPSHOT7 to 1.3.5-SNAPSHOT8 --------- Co-authored-by: version-bump[github-action] <41898282+version-bump[github-action]@users.noreply.github.com> Co-authored-by: Tigerpanzer_02 <[email protected]> Co-authored-by: Wanbin Cao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge yet