chore: improve direct invite by allowing html in someone_invited_you #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fblupi
requested changes
Mar 24, 2023
There was a problem hiding this comment.
If you monkey-patch this file, add it to the spec/lib/overrides_spec.rb. It makes upgrading the Decidim version of the module easier if all the overridden files and customizations are placed there.
Anyway, could you please explain why have you customized this file?
There was a problem hiding this comment.
Thanks for your comment, I will try my best to explain, but will write a test to be sure:
- when the admin checks "register user", the email that is sent is the devise one (as it goes through the
InviteUsercommand). - as we want to have html template for "invitations", this includes direct and registration as well.
Our use-case is a university which will invites all its students, and we need consistency through sent emails.
Will find some time to write tests next week.
Thanks
| @@ -1,7 +1,7 @@ | |||
| <p><%= t("devise.mailer.invitation_instructions.hello", email: @resource.name) %></p> | |||
|
|
|||
| <p> | |||
| <%= t("devise.mailer.invitation_instructions.someone_invited_you", application: @resource.organization.name) %> | |||
| <%= t("devise.mailer.invitation_instructions.someone_invited_you", application: @resource.organization.name).html_safe %> | |||
There was a problem hiding this comment.
You could include a test to check it's working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The direct invitation email is the entry for some collective. The invitation must be well framed and easly readable.
As it is now, we can't set an introduction in the email in html. This is making difficult a proper well framed invitation.
This PR is to change the direct_invite mail to accept html, using the
.html_safeerb filter.Thanks