Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with CivciCRM API v4 #36

Merged
merged 9 commits into from
Jul 29, 2024
Merged

Compatibility with CivciCRM API v4 #36

merged 9 commits into from
Jul 29, 2024

Conversation

alexrlpz
Copy link
Contributor

No description provided.

@alexrlpz alexrlpz requested a review from fblupi June 26, 2024 12:02
fblupi
fblupi requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@fblupi fblupi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small changes and include tests for the parsed_nickname and parsed_name methods in the omniauth class

lib/decidim/civicrm/api.rb Outdated Show resolved Hide resolved
lib/omniauth/strategies/civicrm.rb Outdated Show resolved Hide resolved
lib/omniauth/strategies/civicrm.rb Outdated Show resolved Hide resolved
lib/omniauth/strategies/civicrm.rb Outdated Show resolved Hide resolved
@fblupi fblupi self-requested a review July 29, 2024 15:29
@fblupi fblupi merged commit a62627b into main Jul 29, 2024
2 of 3 checks passed
@fblupi fblupi deleted the feat/api-v4 branch July 29, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fblupi fblupi fblupi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrlpz @fblupi