Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add term_customizer gem #127

Merged
merged 20 commits into from
Oct 15, 2024
Merged

Add term_customizer gem #127

merged 20 commits into from
Oct 15, 2024

Conversation

HHassig
Copy link
Contributor

@HHassig HHassig commented Oct 9, 2024

Added the term_customizer gem.
Set other gems to branch release/0.27-stable.
Needed to hard-code decidim-core, "0.27.5"

@HHassig HHassig requested a review from davidbeig October 9, 2024 14:21
@HHassig HHassig changed the title Add term_customizer gem and fix versioning of other modules Add term_customizer gem Oct 10, 2024
Copy link
Member

@davidbeig davidbeig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the test workflow we can see the following error

warning: parser/current is loading parser/ruby30, which recognizes 3.0.7-compliant syntax, but you are running 3.0.6.

It says that the parser gem recognizes the ruby 3.0.7 syntax but we are running v3.0.6. Following the updates in that gem i found this change. whitequark/parser@31faa0a It looks like that change is the one responsible for this error.

Since parser is not a gem we are using, but one of our dependencies we have to check which one is it.

It's used by

  • rubocop v1.28.2 - parser v3.1.0.0
  • better_html v1.0.16 - parser >= v2.4
  • erb_lint v0.0.37 - parser >= v2.7.1.4
  • i18n-tasks v0.9.37 - parser >= v2.2.3.0
  • rubocop-ast v1.32.3 - parser >= v.3.3.1.0 <--- this one seems to be the responsible

The version installed is: v3.3.5.0, so it has the change i pointed before.

The last version of rubocop-ast to have a dependency on a correct version of parser is v.1.31.2. You can see it here

I think that by adding it to the test group in the Gemfile it will work fine.

Good job with the update of the test workflow :)

@HHassig HHassig force-pushed the feat/term_customizer branch from 9fcd8f5 to 6b7bf9f Compare October 14, 2024 09:56
@HHassig HHassig requested a review from davidbeig October 14, 2024 10:01
Gemfile Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
@fblupi fblupi merged commit e502545 into main Oct 15, 2024
3 checks passed
@fblupi fblupi deleted the feat/term_customizer branch October 15, 2024 13:34
@fblupi fblupi restored the feat/term_customizer branch October 15, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants