Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhardcode api url #520

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Unhardcode api url #520

merged 5 commits into from
Oct 11, 2023

Conversation

z-x
Copy link
Collaborator

@z-x z-x commented Oct 10, 2023

  • When in SvelteKit dev or preview mode, use the default pos-cli 3333 port to get to the API
  • Otherwise (when using the GUI ran from actual pos-cli use the relative path)

@z-x z-x removed the DO NOT MERGE label Oct 10, 2023
@piotrze piotrze merged commit 5b1423d into master Oct 11, 2023
2 checks passed
@piotrze piotrze deleted the unhardcodeApiUrl branch October 11, 2023 08:21
@z-x z-x mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrze piotrze piotrze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z-x @piotrze